type casted $qty to float in \Magento\Catalog\Model\Product::setQty()

[jayankaghosh]

type casted $qty to float in \Magento\Catalog\Model\Product::setQty()

Description

\Magento\Catalog\Model\Product::getQty() should return float/double now, as mentioned in it's Doc-block

Fixed Issues (if relevant)

1. Should getQty() return int/float or string? #18094: Should getQty() return int/float or string?

Manual testing scenarios

1. Observe any event like checkout_cart_product_add_after
2. In the Observer, get an instance of \Magento\Catalog\Model\Product
3. Calling the getQty method of the above-mentioned class would return a float/double instead of string, as expected

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @jayankaghosh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

Hi @jayankaghosh. Thank you for your collaboration.
By bringing the change provided in the current PR we only cover cases when the qty is set using setQty method. However, the product model extends AbstractExtensibleModel and qty can be set via setData('qty').
Maybe we should consider the change within a scope of the getter instead of setter

[jayankaghosh]

@rogyar I made changes to the code to type case in the getter, but then the problem is everytime we get the price, type casting will occur, which may affect performance

[magento-engcom-team]

Hi @jayankaghosh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[Nurgiel]

Should be int not float.