Skip to content

Update CategoryProcessor.php #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ulftietze
Copy link
Member

Description

This fix make it possible, that the upsert category process during product import are generating the freshly created category url rewrites globally and not just for the default scope

Fixed Issues (if relevant)

  1. Product Import -> Upsert Category: Url Rewrites are just created for default website #18234: Product Import -> Upsert Category: Url Rewrites are just created for default website

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 25, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @ulftietze. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ulftietze
Copy link
Member Author

Can be backported to magento 2.2.X

@ulftietze
Copy link
Member Author

Have to be updated, this runs into another more complicated error with URL Rewrites so we shouldn't use this :)
I'm gona update this, if i found a better solution :)

@ulftietze ulftietze closed this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants