Skip to content

[#18269] If import product has missing categories, make a lookup for existing categories to keep the correct url rewrites #18282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ulftietze
Copy link
Member

…existing categories to keep the correct url rewrites

Description

Fixed Issues (if relevant)

  1. Product Import -> Missing categories entry in importfile removes url rewrites #18269: Product Import -> Missing categories entry in importfile removes url rewrites

Manual testing scenarios

  1. Updated Unit Test

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…up for existing categories to keep the correct url rewrites
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ulf Tietze seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Contributor

Hi @ulftietze. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka
Copy link
Member

slavvka commented Sep 28, 2018

Hey @ulftietze. Are you sure that this is a bug? Product may not have categories at all so the current behavior may make sense if a merchant want them to be cleared.

@slavvka slavvka self-assigned this Sep 28, 2018
@ulftietze
Copy link
Member Author

Hey @slavvka,

i'm sure, that this is a bug :)
We have to discuss about, because Magento's Importer as far as i know, is declared as delta update importer. So if you update something, i expect that nothing else is deleted here.
If the product are removed from categories, i think that this would be a correct way to go, but they're keeped into these categories.
This is probably more an error into the url-rewrites and not in the importer, because everytime rewrites for a product are generated, the old one's are deleted. And so it is with the product_category url rewrites.

What do you think about?

@slavvka
Copy link
Member

slavvka commented Oct 2, 2018

Hey @ulftietze. Yes, you are right. Seems that your commit was done with non-github email. Could you please add that email to your GitHub profile or force-push your branch with a new commit with your GitHub email?
Could you also fix the static tests before we can accept your PR? Thank you!

@sidolov
Copy link
Contributor

sidolov commented Oct 16, 2018

Hi @ulftietze , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants