Fix wrong reference in google analytics module layout xml

[sambolek]

Description

Simple change of reference (referenceContainer to referenceBlock) for Google Analytics module.

Fixed Issues (if relevant)

1. Magento 2.2.5: Google Analytics not added to head correctly #16497 Magento 2.2.5: Google Analytics not added to head correctly

Manual testing scenarios

• Observe "head.additional" is created as block app/code/Magento/Catalog/view/frontend/layout/default.xml
• Observe "google_analytics" block is added to storefront by "referenceContainer" in app/code/Magento/GoogleAnalytics/view/frontend/layout/default.xml

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @sambolek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[slavvka]

Although referenceContainer works perfectly with blocks (at least on my instance), I do approve the fix to avoid inconsistencies with overriding it.

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3058 has been created to process this Pull Request

[magento-engcom-team]

Hi @sambolek. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[slavvka]

Hi @sambolek , we need the fix to be delivered also to 2.2-develop branch so please don't forget to port this PR to 2.2-develop; you can do it easily using the Porting Tool, https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html#porting-tool

[sambolek]

Hi @slavvka ,
thanks for the help - made a pull request to 2.2-develop as well now.

[slavvka]

@sambolek Thank you!