Skip to content

[Forwardport] fix #17582 ./bin/magento config:show fails with a fatal error #18295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

[Forwardport] fix #17582 ./bin/magento config:show fails with a fatal error #18295

merged 1 commit into from
Oct 3, 2018

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#17993

Description

Fixed Issues (if relevant)

  1. ./bin/magento config:show fails with a fatal error #17582: ./bin/magento config:show fails with a fatal error

Manual testing scenarios

  1. Fork fresh Magento from GitHub

  2. Install and configure Magento 2

  3. Run the first command php bin/magento config:dump to dump the configuration value

  4. show the config dump php bin/magento config:show (Now it shows correctly the value rather then PHP fatel error) (please check attached file show.txt)
    show.txt

  5. Run the php unit test

$ php vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/Config
PHPUnit 6.2.4 by Sebastian Bergmann and contributors.

............................................................... 63 / 395 ( 15%)
............................................................... 126 / 395 ( 31%)
............................................................... 189 / 395 ( 47%)
............................................................... 252 / 395 ( 63%)
............................................................... 315 / 395 ( 79%)
............................................................... 378 / 395 ( 95%)
................. 395 / 395 (100%)

Time: 855 ms, Memory: 28.00MB

OK (395 tests, 1181 assertions)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3059 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants