Skip to content

pull #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pull #185

wants to merge 1 commit into from

Conversation

yugui5
Copy link

@yugui5 yugui5 commented Jan 6, 2013

删除 .gitignore

@yugui5
删除 .gitignore
99f8e64 
删除 .gitignore
@magento-team
Copy link
Contributor

Hello. Thank you for your contribution. The .gitignore file is useful and should not be deleted.

@amenk
Copy link
Contributor

amenk commented Jan 7, 2013

@mage2-team Can you call a .gitignore in a GIT repository really tool-specific?

@amenk
Copy link
Contributor

amenk commented Jan 7, 2013

Whenever some entries in the suggested .gitignore are indeed 3rd party tool specific (-/.idea) - but I think there should be a Magento specific ignore definition.

@LeeSaferite
Copy link

I guess I'm confused here. yugui5 sent a pull request to delete the .gitignore file and the mage2 team's response is about not taking tool-specific contributions? If anything, deleting the .gitignore file should be 100% in accordance with that desire.

Best would be to do as amenk said an include a .gitignore that excluded Magento specific files that should not be part of the codebase. Things like IDE files/directories belong in a developer specific global ignore or a repo specific ignore.

@magento-team
Copy link
Contributor

Hello. Yes, you're right - Magento specific gitignore makes sense but it probably should not include IDE specific instructions. The .gitignore will stay as is for now.

magento-team pushed a commit that referenced this pull request Mar 23, 2015
@orlangur
Merge pull request #185 from magento-goinc/MAGETWO-35183
2e23323 
[GoInc] Bugfixes
maksek pushed a commit that referenced this pull request Nov 17, 2015
Merge pull request #185 from magento-firedrakes/MAGETWO-45496
3148312 
[Firedrakes] Bugfixes
okorshenko pushed a commit to isitnikov/magento2 that referenced this pull request Aug 10, 2016
@slavvka
Merge pull request magento#185 from magento-east/MAGETWO-55678
91b9405 
[East] MAGETWO-55678: Backport ticket MAGETWO-55460 to 2.0.9
@Igloczek Igloczek mentioned this pull request Mar 27, 2018
Merged
magento-engcom-team added a commit that referenced this pull request Sep 18, 2018
@magento-engcom-team
ENGCOM-2991: GraphQL-80: rename canonical_url to relative_url and fix…
a8f7d61 
… covered test #185

 - Merge Pull Request magento/graphql-ce#185 from pfantini/graphql-ce:80-urlResolver-rename-canonical_url-to-relative_url
 - Merged commits:
   1. c763514
   2. 184f90b
magento-engcom-team pushed a commit that referenced this pull request Sep 18, 2018
ENGCOM-2991: GraphQL-80: rename canonical_url to relative_url and fix…
2eebc49 
… covered test #185
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 9, 2019
@kabothu
Merge pull request magento#185 from magento-pangolin/MC-11505
dd85619 
MC-11505
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 15, 2023
@eliseacornejo @sivaschenko
Lynx-307: country_id and region_id custom attributes (#185)
72ef5ed 
Co-authored-by: Sergii Ivashchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yugui5 @magento-team @amenk @LeeSaferite