Skip to content

[Backport] Fixed typo from filed to field #18556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 12, 2018

Description

Fixed typo from filed to field

Fixed Issues (if relevant)

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#18505

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-3173 has been created to process this Pull Request

@sidolov sidolov changed the title Fixed typo from filed to field [Backport] Fixed typo from filed to field Oct 12, 2018
@sidolov
Copy link
Contributor

sidolov commented Oct 12, 2018

Hi @gelanivishal , we are trying to focus on the 2.3 release line and all code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@gelanivishal
Copy link
Contributor Author

Hello @sidolov, I'll take care of next time while creating a new PR.

Thank you.

@magento-engcom-team magento-engcom-team merged commit aedb6c9 into magento:2.2-develop Oct 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants