Skip to content

[Forwardport] Fix for custom product attribute changing 'backend_type' when 'is_use… #18570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2018
Merged

[Forwardport] Fix for custom product attribute changing 'backend_type' when 'is_use… #18570

merged 1 commit into from
Oct 22, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 12, 2018 •
edited by sidolov
Loading

Original Pull Request

#18196

Description

All is described in referenced issue.

Fixed Issues (if relevant)

  1. Custom Product Attribute changes 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend

Manual testing scenarios

Steps are described in referenced issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal
Fix for custom product attribute changing 'backend_type' when 'is_use…
40e128c 
…r_defined = 1' and get updated/saved in Admin Backend

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3180 has been created to process this Pull Request

@slavvka slavvka mentioned this pull request Oct 22, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 40e128c into magento:2.3-develop Oct 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 22, 2018
ENGCOM-3180: [Forwardport] Fix for custom product attribute changing …
3fd54a4 
…'backend_type' when 'is_use… #18570
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Component: Catalog Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gelanivishal @magento-engcom-team @sidolov