[Forwardport] Fix Customer custom attributes lost after save #18571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17968
Description
The customer model has an attribute
attribute_set_id
that links to its attribute set. It is used while saving, as there is a check to see if its attributes are in the set or not, using this link.We want to avoid a
null
attribute_set_id
.Fixed Issues
Manual testing scenarios
No regression manual test:
6. Programmatically load the customer, add a different not-yet-defined attribute to customer (e.g.
setNotYetDefined(1)
) and save directly using the model.7. Reload the customer: the custom value is still not lost, while
not_yet_defined
is lost.Contribution checklist