Update documentation for Order#getAppliedRuleIds#18573
Update documentation for Order#getAppliedRuleIds#18573magento-engcom-team merged 3 commits intomagento:2.3-developfrom zack6849:2.3-develop
Conversation
Update the documentation for getAppliedRuleIds, as it is not immediately clear if this is a single number in a string, or several that are comma separated.
|
Hi @zack6849. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
rodrigowebjump
left a comment
There was a problem hiding this comment.
Hi, you include an empty line before long description, but removed the line after.
Please, include the empty line after long description :-)
Refer: https://devdocs.magento.com/guides/v2.3/coding-standards/docblock-standard-general.html
rodrigowebjump
left a comment
There was a problem hiding this comment.
Hi @zack6849 Thanks for your contribution
|
Hi @rodrigowebjump, thank you for the review. |
|
merged |
|
Hi @zack6849. Thank you for your contribution. |
Description
Update the documentation for getAppliedRuleIds, as it is not immediately clear if this is a single number in a string, or several that are comma separated.
Manual testing scenarios
Contribution checklist