Skip to content

[Backport] Fix SKU limit in import new products #18591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2018
Merged

[Backport] Fix SKU limit in import new products #18591

merged 3 commits into from
Oct 29, 2018

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Oct 13, 2018 •
edited
Loading

Description (*)

Fix SKU limit in import new products

Fixed Issues (if relevant)

  1. import new products via csv: products are created with empty value when strings are too long #17865: import new products via csv: products are created with empty value when strings are too long

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18639

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 13, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

slavvka
slavvka requested changes Oct 15, 2018
View reviewed changes
Copy link
Member

@slavvka slavvka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Please make changes according to the review results.

app/code/Magento/CatalogImportExport/Model/Import/Product.php Outdated
/**
* SKU max length
*/
const DB_MAX_SKU_LENGTH = 65;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You introduced the constant in the class marked with @api that is backward incompatible (https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/). Additionally the size of sku column is 64, not 65. Please reimplement the solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we want the fixes to be delivered to 2.3 and then backported to 2.2. Please create PR to 2.3
Hello, I have created a new pull request #18639 as per your suggestion based on 2.3 develop branch. Please kindly review it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you for urgent reaction :)

@slavvka slavvka self-assigned this Oct 15, 2018
@slavvka
Copy link
Member

slavvka commented Oct 15, 2018

Also we want the fixes to be delivered to 2.3 and then backported to 2.2. Please create PR to 2.3

@ravi-chandra3197 ravi-chandra3197 changed the title Fix SKU limit in import new products [Backport] Fix SKU limit in import new products Oct 16, 2018
@ravi-chandra3197 ravi-chandra3197 mentioned this pull request Oct 18, 2018
Merged
4 tasks
@ravi-chandra3197
Copy link
Contributor Author

Hi @slavvka can you review it
I have changed as per your suggestions now it allows the product with SKU that contains 64 characters.

@slavvka
Copy link
Member

slavvka commented Oct 22, 2018

hey @ravi-chandra3197 thank you for the changes. Looks good

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 29, 2018
@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3321 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3321 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 29, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ad68105 into magento:2.2-develop Oct 29, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 29, 2018
ENGCOM-3321: [Backport] Fix SKU limit in import new products #18591
79a09c9
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sivaschenko sivaschenko mentioned this pull request Nov 16, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@slavvka slavvka

@sidolov sidolov

Labels
Component: CatalogImportExport Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@ravi-chandra3197 @magento-cicd2 @magento-engcom-team @slavvka @sidolov