Ensure integer values are not quoted as strings#18611
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Oct 27, 2018
Merged
Ensure integer values are not quoted as strings#18611magento-engcom-team merged 1 commit intomagento:2.3-developfrom
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
Conversation
Contributor
|
Hi @udovicic. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
4 tasks
miguelbalparda
approved these changes
Oct 15, 2018
Contributor
Contributor
|
Hi @udovicic. Thank you for your contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
In cases where indexers does a filtering in the style of WHERE entity_id IN (...) there is a performance penalty if IDs are passed as strings, rather than integer values. This is especially visible on larger data sets. This pull request should cover some common occurrences of this.
This is based on the PR #18287 , as requested.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)