[BUGFIX] [issue-10205] Always set the entity_type_id for updating pro…

[lewisvoncken]

…duct attributes because the route contains the specification products/attributes

Description (*)

issue description which is solved:

Using Magento 2.1.7 with the REST API - POST /V1/products/attributes - I can add a new attribute and configure it with settings such as is_filterable.

This is all fine but if I then want to change this setting I can't. I have tried with POST and with PUT /V1/products/attributes/{attributeCode}. The command works as in it will update, for instance, the frontend label in the eav_attribute table, but it does not seem to have any effect on values in the catalog_eav_attribute table.

Fixed Issues (if relevant)

1. REST API /V1/products/attributes does not update all properties #10205: REST API /V1/products/attributes does not update all properties

Manual testing scenarios (*)

1. Add a new attribute using REST API - POST - /V1/products/attributes - with is_filterable set to false.
2. Update the same attribute using either the same POST url or PUT - /V1/products/attributes/{attributeCode} and set the is_filterable field to true
3. Result: attribute is not set to is_filterable
4. Apply changes
5. Update the same attribute using either the same POST url or PUT - /V1/products/attributes/{attributeCode} and set the is_filterable field to true
6. Result: attribute is set to is_filterable

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @lewisvoncken. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @lewisvoncken. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.