Skip to content

[Backport] Issue Fixed: Missing Fixed Product Tax total on PDF #18649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

[Backport] Issue Fixed: Missing Fixed Product Tax total on PDF #18649

merged 1 commit into from
Nov 9, 2018

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Oct 16, 2018 •
edited by sidolov
Loading

Issue of Wee Tax When using FPT, the FPT-total show up at the cart/checkout but is missing at the pdf invoice.

Description (*)

If we enable FPT and add it to the product, after placing order, FTP amount field is displaying on Order view, Invoice view etc, when downloading Invoice Pdf, FTP amount field was missing. In this pull request
i have fixed it.

Fixed Issues (if relevant)

  1. Missing Fixed Product Tax total on PDF #18617

Manual testing scenarios (*)

  1. Enable FPT from Stores > Settings > Configurations > Sales > Tax > Fixed Product Taxes.
  2. Created a new product attribute of type FPT.
  3. Added this attribute to Default attribute set.
  4. Saved product with FTP details.
  5. Placed an order and generated invoice.
  6. Print pdf.

Finally FPT column is visible on invoice pdf.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #19061

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat
Copy link
Member Author

#SQUASHTOBERFEST

@larsroettig larsroettig self-requested a review October 17, 2018 10:18
@larsroettig larsroettig self-assigned this Oct 17, 2018
@mahesh-rajawat
Copy link
Member Author

@larsroettig why its in still pending, do i need to do any thing else?

@larsroettig larsroettig removed their assignment Nov 1, 2018
@larsroettig larsroettig removed their request for review November 1, 2018 15:29
mahesh-rajawat added a commit to mahesh-rajawat/magento2 that referenced this pull request Nov 4, 2018
@mahesh-rajawat
Fixed Product Tax total on PDF for 2.3, Reference of PL magento#18649
73ff7cb
@mahesh-rajawat mahesh-rajawat mentioned this pull request Nov 4, 2018
Merged
4 tasks
@vadimjustus vadimjustus self-requested a review November 5, 2018 14:44
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vadimjustus, thank you for the review.
ENGCOM-3394 has been created to process this Pull Request

@sidolov sidolov changed the title Issue Fixed: Missing Fixed Product Tax total on PDF [Backport] Issue Fixed: Missing Fixed Product Tax total on PDF Nov 9, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Nov 9, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 382e550 into magento:2.2-develop Nov 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 9, 2018
ENGCOM-3394: Issue Fixed: Missing Fixed Product Tax total on PDF #18649
9daf711
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

magento-engcom-team added a commit that referenced this pull request Nov 12, 2018
@magento-engcom-team
ENGCOM-3393: Fixed Product Tax total on PDF for 2.3, Reference of PL #…
826732a 
…18649 #19061

 - Merge Pull Request #19061 from maheshWebkul721/magento2:wee-tax2.3
 - Merged commits:
   1. 73ff7cb
magento-engcom-team pushed a commit that referenced this pull request Nov 12, 2018
ENGCOM-3393: Fixed Product Tax total on PDF for 2.3, Reference of PL #…
bd661b2 
…18649 #19061
magento-engcom-team added a commit that referenced this pull request Nov 12, 2018
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
57d7010 
Accepted Public Pull Requests:
 - #18814: Replace erroneous usage of unsData method (by @t-richards)
 - #19061: Fixed Product Tax total on PDF for 2.3, Reference of PL #18649 (by @maheshWebkul721)
 - #18816: Issue #18150 fixed: Reference Pull Request of #18815 for 2.3-develop  (by @maheshWebkul721)
 - #15961: 14294 - Fixes 'back' functionality after switching a store view. (by @Mobecls)


Fixed GitHub Issues:
 - #18617: Missing Fixed Product Tax total on PDF (reported by @Detzler) has been fixed in #19061 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. 73ff7cb

 - #18150: Backups error from User Roles Permission 2.2.6 (reported by @andy17612) has been fixed in #18816 by @maheshWebkul721 in 2.3-develop branch
   Related commits:
     1. 3d0d8b7

 - #14294: Since MagentoCE2.1.11, after swithing store view, ___store=xx is added to url. Breaks 'back' functionality. (reported by @bobemoe) has been fixed in #15961 by @Mobecls in 2.3-develop branch
   Related commits:
     1. 3feda05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimjustus vadimjustus vadimjustus approved these changes

@phoenix128 phoenix128 Awaiting requested review from phoenix128

Assignees

@vadimjustus vadimjustus

Labels
Component: Weee Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@mahesh-rajawat @magento-engcom-team @vadimjustus @larsroettig