Skip to content

Remove unnecessary class import, see #18280 #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 17, 2018

Description (*)

In magento2/#18280 this was added to sort the collection ...

use Magento\Framework\Data\Collection;`
...
->setDirection(Collection::SORT_ORDER_ASC)

Instead we can use setAscendingDirection(). If not Magento\Framework\Api\SortOrder::SORT_ASC would be more correct. (?)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sreichel sreichel requested a review from dmytro-ch October 17, 2018 13:11
@sreichel sreichel changed the title Remove necessary class import, see #18280 Remove unnecessary class import, see #18280 Oct 17, 2018
@orlangur orlangur self-assigned this Oct 17, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3211 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sreichel sreichel deleted the develop/18280-cs branch October 30, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants