Skip to content

Issue #17436 fixed: Notice: Undefined index: newProduct while saving configurable product.#18789

Closed
mahesh-rajawat wants to merge 1 commit intomagento:2.3-developfrom
mahesh-rajawat:save-config-product
Closed

Issue #17436 fixed: Notice: Undefined index: newProduct while saving configurable product.#18789
mahesh-rajawat wants to merge 1 commit intomagento:2.3-developfrom
mahesh-rajawat:save-config-product

Conversation

@mahesh-rajawat
Copy link
Copy Markdown
Member

Tried to save Configurable product with at least one associated product having 64 character length of SKU, then it throws an error: Notice: Undefined index: newProduct .

Description (*)

Configurable product can be saved with associated product having 64 character length SKU.
it was throwing an error Notice: Undefined index: newProduct in file /app/code/Magento/ConfigurableProduct/Controller/Adminhtml/Product/Initialization/Helper/Plugin/Configurable.php on line 161. In this pull request i have fixed it.

Fixed Issues (if relevant)

  1. Undefined variables during product save #17436

Manual testing scenarios (*)

  1. After fixed it, i have created a configurable product with one associated product having last possible
    character length SKU, now products getting created as simple product.
  2. Checked the same scenario with Edit configurable product.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Oct 25, 2018

Hi @maheshWebkul721 , looks like the same issue was fixed in #18462 and this PR is a duplicate.
What do you think?

@mahesh-rajawat
Copy link
Copy Markdown
Member Author

@sidolov i got it, i will close this issue.

@mahesh-rajawat mahesh-rajawat deleted the save-config-product branch October 25, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants