fixed Product Advanced Pricing design issue #18775#18790
Merged
magento-engcom-team merged 1 commit into2.3-developfrom Oct 27, 2018
unknown repository
Merged
fixed Product Advanced Pricing design issue #18775#18790magento-engcom-team merged 1 commit into2.3-developfrom unknown repository
magento-engcom-team merged 1 commit into2.3-developfrom
unknown repository
Conversation
Contributor
Contributor
|
Hi @ashutoshwebkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Oct 25, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
Contributor
|
@ashutoshwebkul thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Author
|
#squashtoberfest |
Contributor
|
Hi @ashutoshwebkul. Thank you for your contribution. |
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
There was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible="$data.labelVisible" was on child element of the label, because of that parent was still visible even if the label visibility was false.
Fixed Issues (if relevant)
Manual testing scenarios (*)
3: click on Add Product button
4: fill details then click on Advanced Pricing
5: in customer group price click Add
Contribution checklist (*)