Remove php.ini sample

[wiardvanrij]

Description (*)

The current php.ini.sample is really outdated and is not really "mature". It is simple to provide users with the basics, which is only things about memory_limit at the moment. For the rest users should refer to the Magento2 version requirements.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @wiardvanrij. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@wiardvanrij memory limit is already covered in Magento dev docs as well, why do we need this file at all then?

[wiardvanrij]

@orlangur Oh I agree, it would be better to remove it :) - updated

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3303 has been created to process this Pull Request

[magento-engcom-team]

Hi @wiardvanrij. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[ncioj10]

I think it is not very good to entirely remove this file. Is it possible to provide a updated version, as there are only bits of information flying around about this topic?

[orlangur]

@ncioj10 https://devdocs.magento.com/guides/v2.3/install-gde/prereq/php-settings.html should contain all the needed settings. If it's not true, it should be fixed instead of adding some file here.