Skip to content

[Backport] Fixes #18357 - SQL error when table prefix used. #18866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 27, 2018

Original PR

#18412

Description

Hard-coded table names cause errors if a table prefix, passing the table name to getTable resolves this.

Fixed Issues (if relevant)

  1. checkout_agreement_store doesn't exist #18357
    Magento 2.2.6 Terms and Conditions are Not visible in Admin #18954

Manual testing scenarios

  1. Create a store using table prefixes
  2. Navigate to Store > Terms and Conditions in the admin backend
  3. Without the patch, errors are generated

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gelanivishal
Copy link
Contributor Author

@VladimirZaets I can't find any Codacy/PR Quality Review error. Can you processed this PR?

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3989 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @gelanivishal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Ctucker9233
Copy link

@magento-engcom-team Why was this moved from the 2.2.8 release to 2.2.9? It seems like a simple fix that should be released asap as it has caused many including myself significant problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants