-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Fixes #18357 - SQL error when table prefix used. #18866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fixes #18357 - SQL error when table prefix used. #18866
Conversation
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
app/code/Magento/CheckoutAgreements/Model/ResourceModel/Agreement/Grid/Collection.php
Show resolved
Hide resolved
@VladimirZaets I can't find any Codacy/PR Quality Review error. Can you processed this PR? |
Hi @sidolov, thank you for the review. |
Hi @gelanivishal, thank you for your contribution! |
@magento-engcom-team Why was this moved from the 2.2.8 release to 2.2.9? It seems like a simple fix that should be released asap as it has caused many including myself significant problems. |
Original PR
#18412
Description
Hard-coded table names cause errors if a table prefix, passing the table name to getTable resolves this.
Fixed Issues (if relevant)
Magento 2.2.6 Terms and Conditions are Not visible in Admin #18954
Manual testing scenarios
Contribution checklist