Skip to content

added config for catalog review in frontend #18895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2018
Merged

added config for catalog review in frontend #18895

merged 3 commits into from
Dec 21, 2018

Conversation

torhoehn
Copy link
Contributor

@torhoehn torhoehn commented Oct 27, 2018 •
edited
Loading

Description

Until now there wasn't a config field to hide product review elements from frontend. I orientated at the wishlist module, because for wishlist it was already possible.

Manual testing scenarios

  1. Open Backend
  2. Go to Stores -> Configuration -> Catalog -> Catalog -> Product Reviews
  3. Set 'Enabled' to 'No'
  4. Newsletter will be hidden from catalog product view, customer account, customer account sidebar, ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@larsroettig larsroettig self-requested a review October 30, 2018 20:04
@larsroettig larsroettig self-assigned this Oct 30, 2018
larsroettig
larsroettig requested changes Nov 5, 2018
View reviewed changes
@torhoehn torhoehn requested a review from sivaschenko November 25, 2018 10:14
sivaschenko
sivaschenko reviewed Nov 26, 2018
View reviewed changes
sivaschenko
sivaschenko requested changes Nov 26, 2018
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torhoehn Thank you for the contribution. Please see the review notes

@sivaschenko sivaschenko self-assigned this Nov 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 26, 2018
@larsroettig
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, here is your new Magento instance.
Admin access: https://pr-18895.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@larsroettig
Copy link
Member

larsroettig commented Nov 26, 2018 •
edited
Loading

✅ Code Review
✅ Manual Testing

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3572 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 42dd7a6 into magento:2.3-develop Dec 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2018
@sidolov
ENGCOM-3572: added config for catalog review in frontend #18895
154590b
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@torhoehn torhoehn deleted the feature/review-config branch December 22, 2018 08:31
@torhoehn torhoehn mentioned this pull request Dec 22, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@larsroettig larsroettig larsroettig approved these changes

Assignees

@sivaschenko sivaschenko

@larsroettig larsroettig

Labels
Area: Frontend Award: complex Component: Review Partner: Basecom partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@torhoehn @magento-engcom-team @larsroettig @sivaschenko @p-bystritsky