Skip to content

[Backport] fixed - can't import external http to https redirecting images by default csv import #18899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Nov 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2018

Description (*)

I think we should handle 302 redirection. We should check the next header if there is 302 redirection with url.

Fixed Issues (if relevant)

  1. can't import external http to https redirecting images by default csv import #18839: can't import external http to https redirecting images by default csv import

Manual testing scenarios (*)

  1. Use any image url with redirection like http://midwest-wholesale-staging.cloud.akeneo.com/bundles/pimui/images/info-user.png
  2. It will redirect to https://midwest-wholesale-staging.cloud.akeneo.com/bundles/pimui/images/info-user.png and it is valid image.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Backport for: #18900

@magento-engcom-team
Copy link
Contributor

Hi @rahulwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost changed the title fixed - can't import external http to https redirecting images by def… fixed - can't import external http to https redirecting images by default csv import Oct 28, 2018
@sidolov sidolov changed the title fixed - can't import external http to https redirecting images by default csv import [Backport] fixed - can't import external http to https redirecting images by default csv import Oct 29, 2018
@sivaschenko sivaschenko self-assigned this Nov 22, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3528 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rahulwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants