Fix the issue with missing asterisk for admin required fields

[dmytro-ch]

Preconditions

There is a missing asterisk for admin required fields.

Description (*)

Looks like the issue was accidentally caused by the following commit: 7d4721d

1. The same fix should be applied as for the Magento 2.3 in order to fix the issue: eb173dd
2. Also, the following temporary fix for admin login form should be reverted: af70049

Fixed Issues

1. Missing asterisk for admin required fields #18904: Missing asterisk for admin required fields

Manual testing scenarios (*)

1. Check the admin form with required fields. (E.g. Admin login page, admin order create page etc.)

Expected result

1. The asterisk is shown for the required foelds.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18905-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[rogyar]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18905//admin
Login: admin Password: 123123q

[sidolov]

Hi @dmytro-ch , we found few test failures with current solution:

MTF / Functional-Tests-CE / Functional Tests CE - MTF / isolate:3:39:Magento_Catalog_Test_TestCase_Product_CreateSimpleProductEntityPartTwoTest / Magento\Catalog\Test\TestCase\Product\CreateSimpleProductEntityPartTwoTest.testCreate with data set "CreateSimpleProductEntityTestVariation23_0"

MTF / Functional-Tests-CE / Functional Tests CE - MTF / 6:55:4 / Magento\Catalog\Test\TestCase\ProductAttribute\CreateAttributeSetEntityTest.testCreateAttributeSet with data set "CreateAttributeSetEntityTestVariation1_0"

MTF / Functional-Tests-CE / Functional Tests CE - MTF / 6:55:4 / Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityFromProductPageTest.test with data set "CreateProductAttributeEntityFromProductPageTestVariation1_Searchable_Global_Visible_Comparable_HtmlAllowed_UsedForSorting_0"

MTF / Functional-Tests-CE / Functional Tests CE - MTF / 6:55:4 / Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest.testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation2_0"

MTF / Functional-Tests-CE / Functional Tests CE - MTF / 6:55:4 / Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest.testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation6_0"

MTF / Functional-Tests-CE / Functional Tests CE - MTF / 6:55:4 / Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest.testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation7_0"

Please, take a look

[dmytro-ch]

For now, I've resolved the mentioned failures, except the "CreateProductAttributeEntityTest" test.
Will continue investigating the issue.

[sidolov]

Hi @dmytro-ch , will you continue work on this?
Thank you!

[dmytro-ch]

Hello @sidolov.
Unfortunately, I could not resolve the issue with failing functional tests yet.

The problem should be related to my local environment setup, considering the same tests permanently fail in 2.2-develop branch.

Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest::testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation3_0" (CreateProductAttributeEntityTestVariation3_0)
Exception: Container is not found "conditions""

Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest::testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation6_0" (CreateProductAttributeEntityTestVariation6_0)
Products attribute options are absent on product form: blue
Failed asserting that false is true.

Magento\Catalog\Test\TestCase\ProductAttribute\CreateProductAttributeEntityTest::testCreateProductAttribute with data set "CreateProductAttributeEntityTestVariation8_0" (CreateProductAttributeEntityTestVariation8_0)
Product Attribute is absent on Product form.
Failed asserting that false is true.

I'm using:

• ChromeDriver: 2.43.600233
• Chrome headless: 70.0.3538.102
• Selenium: 3.4.0

I was also trying to use PhantomJS and Firefox instead of Chrome, but encountered another issue.

I'm not sure I can finish this PR soon. So the issue can be passed to another developer, in order to finish it ASAP.

Thank you!

[sidolov]

Hi @dmytro-ch , try to use older version of selenium, for example, 2.53.1 and corresponded driver for it.

[dmytro-ch]

@sidolov, thank you for the recomendations.

I've downgraded following dependencies:

• ChromeDriver: 2.21.371461
• Chrome headless: 50.0.2661.75
• Selenium: 2.53.1

But exactly the same issues still arise as previously.

I'm running the test separately on clean database.

vendor/bin/phpunit --filter CreateCategoryEntityTest

All the required system configs are also set (https://devdocs.magento.com/guides/v2.2/mtf/mtf_quickstart/mtf_quickstart_magento.html).
All the dependencies are up to date.

[magento-engcom-team]

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.