Add missing unit test for WishlistSettings plugin #18906
Conversation
magento-engcom-team
added
Partner: Atwix
|
Hi @dmytro-ch. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@dmytro-ch I really doubt the test is "missing" here. Raised this question in Slack. |
There was a problem hiding this comment.
@dmytro-ch thanks for your contribution.
My personal feeling is that we should concentrate on methods with maximum C.R.A.P. index instead of simple ones, as when simple method becomes complex usually you would have to change test too much. Still this topic does not seem to bring a lot of attention in Slack, probably there is no recommendation currently or even it contradicts to my feelings.
| $subjectMock = $this->createMock(DataProvider::class); | ||
| $result = []; | ||
| $isAllow = true; | ||
| $this->helperMock->expects($this->once())->method('isAllow')->willReturn(true); |
There was a problem hiding this comment.
Generally, please avoid strict checks like expects($this->once()) in order to not make test too fragile.
In order to check method behavior rather than execution flow here the only thing to be asserted is new array key added.
|
Hi @orlangur, thank you for the review. |
|
@orlangur thank you for the details! :) |
|
Hi @dmytro-ch. Thank you for your contribution. |
Description (*)
Add missing unit test for
\Magento\Wishlist\Plugin\Ui\DataProvider\WishlistSettingsclass.Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Contribution checklist (*)