Skip to content

[#18269] If import product has missing categories, make a lookup for existing categories to keep the correct url rewrites #18942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ulftietze
Copy link
Member

@ulftietze ulftietze commented Oct 30, 2018

…existing categories to keep the correct url rewrites

Description

Fixed Issues (if relevant)

  1. Product Import -> Missing categories entry in importfile removes url rewrites #18269: Product Import -> Missing categories entry in importfile removes url rewrites

Manual testing scenarios

  1. Updated Unit Test

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Ulf Tietze and others added 2 commits September 27, 2018 11:38
@magento-engcom-team
Copy link
Contributor

Hi @ulftietze. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Include some docs blocs to fix static tests.
@aleron75 aleron75 self-assigned this Nov 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3367 has been created to process this Pull Request

@aleron75
Copy link
Contributor

aleron75 commented Nov 2, 2018

Hello @ulftietze thank you for your contribution.

Once merged, don't forget you can easily port this PR to other branches with the Porting Tool, read more here.

If you already did it and I missed it, please ignore my message.

Cheers

@sidolov
Copy link
Contributor

sidolov commented Nov 9, 2018

Hi @ulftietze , we cannot reproduce described issue:

Manual testing scenario:

  1. Two websites are created: base and second
  2. Simple product is created on both websites: base and second.
  3. Simple product is assigned to categories: Default Category/cat1,Default Category/cat2.
  4. URL Rewrite contains following informations:
    18942beforeimport

Import csv with following information:
sku,url_key,product_websites simple1,custom-url-key-for-product-123456789,"base,second"

Url rewrites for categories are present in url_rewrite table.
18942afterimport

@sivaschenko
Copy link
Member

@ulftietze closing the pull request due to inactivity. Feel free to reopen is you will have any additional details for us to reproduce the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants