-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed annotations #18946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed annotations #18946
Conversation
- Magento\Catalog\Model\ResourceModel\Product\Collection::addAttributeToFilter() - Magento\Quote\Model\QuoteAddress::setCollectShippingRates()
Hi @sreichel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @VladimirZaets, thank you for the review. |
- Magento\Customer\Model\Address\AbstractAddress::getCountry() - Magento\Customer\Model\Address\AbstractAddress::getCountryId()
setData() should return objects class - that inherits from
Hi @sreichel. Thank you for your contribution. |
Description (*)
Fixed someannotations that code analysation had complained about:
array
is a valid input type foraddAttributeToFilter()
Everywhere in code
setCollectShippingRates()
usestrue
as parameter, but annotation wants an integer.getCountryId()
andgetCountry()
returns a string, not an integersetData()
returns\Magento\Framework\DataObject
instead of$this
Fixed Issues (if relevant)
Contribution checklist (*)