Fixed annotations#18946
Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom Nov 5, 2018
Merged
Conversation
- Magento\Catalog\Model\ResourceModel\Product\Collection::addAttributeToFilter() - Magento\Quote\Model\QuoteAddress::setCollectShippingRates()
Contributor
|
Hi @sreichel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Oct 30, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
- Magento\Customer\Model\Address\AbstractAddress::getCountry() - Magento\Customer\Model\Address\AbstractAddress::getCountryId()
setData() should return objects class - that inherits from
Contributor
|
Hi @sreichel. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed someannotations that code analysation had complained about:
arrayis a valid input type foraddAttributeToFilter()Everywhere in code
setCollectShippingRates()usestrueas parameter, but annotation wants an integer.getCountryId()andgetCountry()returns a string, not an integersetData()returns\Magento\Framework\DataObjectinstead of$thisFixed Issues (if relevant)
Contribution checklist (*)