Save product using repository in adminhtml controller

[JeroenVanLeusden]

Description (*)

Save product in Magento\Catalog\Controller\Adminhtml\Product\Save using Repository. Will be much easier to customize the flow if a plugin can be created on the Repository::save() method.

Fixed Issues (if relevant)

1. None I could find.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

Not sure if it will pass the builds but let's try. A bit surprised $saveOptions is not used anymore.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3337 has been created to process this Pull Request

[orlangur]

@JeroenVanLeusden please check tests failing on Travis CI.

[sivaschenko]

@orlangur @JacobBrownAustin I don't think Travis fails are related to the PR

[sivaschenko]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-18950.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[p-bystritsky]

@JeroenVanLeusden this improvement is incorrect, as ProductRepository currently is trying to load product by sku before saving it.

magento2/app/code/Magento/Catalog/Model/ProductRepository.php

Line 578 in 6cc68c6

$existingProduct = $this->get($product->getSku());

So creating new product with existing sku will just override existing one instead of creating new with the modified sku.
You can try to fix this bug or wait until magento-engcom/import-export-improvements#119 would be merged, as this PR may resolve this problem.

[JeroenVanLeusden]

@p-bystritsky I can wait till that PR is merged. Does that mean I have to wait till the fixed is merged into main line and re-submit the PR?

[p-bystritsky]

@JeroenVanLeusden, no, just wait.

[m2-assistant]

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.