Backport [PR 18772] Remove unnecesary "header" block redeclaration #18964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Same as pull request #18772
Removed because the "header" block was already created in module Magento_Theme, so this redeclaration is just unnecesary
Fixed Issues (if relevant)
None found on the Magento 2 issues
Manual testing scenarios (*)
Create new module.
Create new default.xml and try to use referenceBlock to set the template. Example:
<referenceBlock name="header"> <arguments> <argument name="template" xsi:type="string">Samuel27m_Welcome::html/header.phtml</argument> </arguments> </referenceBlock>
Doesn't work, because Luma theme XML files are compiled after all modules and overrides the custom module modifications.
Contribution checklist (*)