[Forwardport] #17890: show correct text swatch values per store view#18988
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Nov 6, 2018
nmalevanec:2.3-develop-PR-port-17891
Merged
[Forwardport] #17890: show correct text swatch values per store view#18988magento-engcom-team merged 1 commit intomagento:2.3-developfrom nmalevanec:2.3-develop-PR-port-17891
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-17891
Conversation
Contributor
|
Hi @nmalevanec. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Nov 1, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
Contributor
|
Hi @nmalevanec. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17891
Description
Show correct text swatches values per store view.
Fixed Issues (if relevant)
Manual testing scenarios
sizeattribute.XS D. And for admin store setXS Asizeattribute should haveXS Dvalue instead ofXS AContribution checklist