Add additional check if password hash is empty in auth process#19066
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Nov 6, 2018
progreg:issue-19060-mage23
Merged
Add additional check if password hash is empty in auth process#19066magento-engcom-team merged 1 commit intomagento:2.3-developfrom progreg:issue-19060-mage23
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
progreg:issue-19060-mage23
Conversation
Contributor
|
Hi @progreg. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Nov 5, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
Contributor
|
Hi @progreg. Thank you for your contribution. |
4 tasks
salehawal
reviewed
Jun 20, 2019
salehawal
left a comment
There was a problem hiding this comment.
i also found a isue in this methud, after changing the return value format it did work fine
public function isValidHash($password, $hash)
{
$this->explodePasswordHash($hash);
foreach ($this->getPasswordVersion() as $hashVersion) {
$password = $this->hash($this->getPasswordSalt() . $password, $hashVersion);
}
$hash = $this->getPasswordHash();
return Security::compareStrings(
$password,
$hash
);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added additional check for password hash if the customer was created without a password from admin area.
Fixed Issues
Manual testing scenarios
Contribution checklist