-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Calling getCurrentUrl on Store will wrongly add "___store" parameter #18941 #19135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
magento-engcom-team
merged 10 commits into
magento:2.3-develop
from
Nazar65:issue-18941
Dec 19, 2018
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0e8cd9f
Calling getCurrentUrl on Store will wrongly add "___store"
Nazar65 300772d
Fix issue 18941
Nazar65 b9a37ce
Merge remote-tracking branch 'origin' into issue-18941
Nazar65 1378074
Revert "Customer related values are NULL for guests"
Nazar65 70d76c7
Merge branch 'issue-18941' of https://github.com/Nazar65/magento2 int…
Nazar65 2e5697d
Revert "Customer related values are NULL for guests"
Nazar65 b9f72f7
Revert "Customer related values are NULL for guests"
Nazar65 22edbb9
Revert "Customer related values are NULL for guests"
Nazar65 3c869e7
Cover changes with interation tests
Nazar65 f1363cf
Fix failed tests unit, static, integration
Nazar65 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that URL is generated in Magento framework, not passed from outside, can you please reorganize the code to prevent adding store code to the URL instead of cutting it off after it is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method getUrl add parameters to url for specified scope,
$url = $this->_url->setScope($this);
Is this right to change this on getUrl method?