Skip to content

Add availability to leave empty config for events.xml #19146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2018
Merged

Add availability to leave empty config for events.xml #19146

merged 2 commits into from
Nov 29, 2018

Conversation

lisovyievhenii
Copy link
Contributor

Description (*)

Forwardport of PR #19145
Related issue #15931: events.xml cant have no childrens, others can [Magento 2.2.4]

@lisovyievhenii lisovyievhenii added the Partner: ISM eCompany Pull Request is created by partner ISM eCompany label Nov 10, 2018
@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Component: Framework/Event labels Nov 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @lisovyievhenii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Nov 10, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 10, 2018
@rogyar
Copy link
Contributor

rogyar commented Nov 10, 2018

Hi @lisovyievhenii. Please, consider fixing failing tests

@lisovyievhenii
Copy link
Contributor Author

Please re-run tests, because it was failed due timeout.

@magento-engcom-team magento-engcom-team mentioned this pull request Nov 29, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 7ae271e into magento:2.3-develop Nov 29, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 29, 2018
@sivaschenko
ENGCOM-3422: Add availability to leave empty config for events.xml #1…
d31950d 
…9146
@magento-engcom-team
Copy link
Contributor

Hi @lisovyievhenii. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@lisovyievhenii lisovyievhenii mentioned this pull request Nov 30, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rogyar rogyar

Labels
Component: Framework/Event Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lisovyievhenii @magento-engcom-team @rogyar