Skip to content

Reducing space when there is no message on the page #19295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2018
Merged

Reducing space when there is no message on the page #19295

merged 2 commits into from
Dec 9, 2018

Conversation

rodrigoobiassi
Copy link
Member

  • There is an unnecessary fixed size in the message area that leaves the title very separate from the top

@magento-engcom-team
Copy link
Contributor

Hi @rodrigoobiassi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Nov 21, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3506 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@rodrigoobiassi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@rodrigoobiassi
Copy link
Member Author

Thanks guys, I already accepted Community Contributors team invitation.

@magento-engcom-team magento-engcom-team merged commit a2a633b into magento:2.3-develop Dec 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rodrigoobiassi. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Dec 9, 2018
@sidolov
ENGCOM-3506: Reducing space when there is no message on the page #19295
af8cc0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Area: Frontend Component: Customer Partner: Imagination Media partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigoobiassi @magento-engcom-team @VladimirZaets @p-bystritsky