Skip to content

[Backport] Fix the issue with repetitive "tbody" tag for order items table #19358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Nov 23, 2018

Original Pull Request

#19299

Fix the issue with repetitive "tbody" tag for order items table.

Description (*)

There is an issue with repetitive "tbody" tag for order items table. As result, the incorrect styles are applied for the table.
The "striped table" styles, defined in app/design/frontend/Magento/luma/Magento_Customer/web/css/source/_module.less:179, expected to be used for Luma theme.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Check the order/return items tables for both guest and customer.

Expected result

  1. There is no repetitive "tbody" for order items table.
  2. As result, the "striped table" styles should be applied.

screen shot 2018-11-21 at 1 51 28 pm

This is the expected view of the table, defined in app/design/frontend/Magento/luma/Magento_Customer/web/css/source/_module.less:179.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Nov 23, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3544 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants