Fixing a test for Magento Newsletter.

[tiagosampaio]

Fixing a test for Magento Newsletter.

Description

The problem occurred because the constructor is being considered. By running the phpunit directly you can check this error out.

> php ./vendor/bin/phpunit -c ./dev/tests/unit/phpunit.xml.dist ./app/code/Magento/Newsletter

The tests will break.

1) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddSubscriberData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

2) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddQueueData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

3) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddErrorData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

4) Magento\Newsletter\Test\Unit\Model\ProblemTest::testGetSubscriberWithNoSubscriberId
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

5) Magento\Newsletter\Test\Unit\Model\ProblemTest::testGetSubscriber
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

6) Magento\Newsletter\Test\Unit\Model\ProblemTest::testUnsubscribeWithNoSubscriber
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

7) Magento\Newsletter\Test\Unit\Model\ProblemTest::testUnsubscribe
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

@tiagosampaio how this test is broken?

[rodrigowebjump]

Hi @tiagosampaio Thanks for your contribution

[magento-engcom-team]

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3549 has been created to process this Pull Request

[tiagosampaio]

Hi @rodrigowebjump! Thank you for the review.

[tiagosampaio]

@tiagosampaio how this test is broken?

@orlangur the problem occurred because the constructor is being considered. By running the phpunit directly you can check this error out.

> php ./vendor/bin/phpunit -c ./dev/tests/unit/phpunit.xml.dist ./app/code/Magento/Newsletter

The tests will break.

1) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddSubscriberData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

2) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddQueueData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

3) Magento\Newsletter\Test\Unit\Model\ProblemTest::testAddErrorData
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

4) Magento\Newsletter\Test\Unit\Model\ProblemTest::testGetSubscriberWithNoSubscriberId
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

5) Magento\Newsletter\Test\Unit\Model\ProblemTest::testGetSubscriber
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

6) Magento\Newsletter\Test\Unit\Model\ProblemTest::testUnsubscribeWithNoSubscriber
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

7) Magento\Newsletter\Test\Unit\Model\ProblemTest::testUnsubscribe
ArgumentCountError: Too few arguments to function Magento\Newsletter\Model\SubscriberFactory::__construct(), 0 passed in /Users/tiagosampaio/Sites/OpenSource/Magento2/vendor/phpunit/phpunit-mock-objects/src/Generator.php on line 216 and at least 1 expected

/Users/tiagosampaio/Sites/OpenSource/Magento2/generated/code/Magento/Newsletter/Model/SubscriberFactory.php:29
/Users/tiagosampaio/Sites/OpenSource/Magento2/app/code/Magento/Newsletter/Test/Unit/Model/ProblemTest.php:71

[orlangur]

@tiagosampaio suspected something like that) Please put such kind of information to the description so that error can be easily reproduced by QA engineers.

Wondering, how many such non-runnable separately tests we have.

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-3549 has been created to process this Pull Request

[tiagosampaio]

@orlangur I just added the description. I've checked here and some others are breaking. I'll create a pull request for them too.

[magento-engcom-team]

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.