fixed Negative order amount in dashboard - #18754

[niravkrish]

Fixed issue of Negative order amount in dashboard latest order when order is cancelled where coupon has been used #18754

Description (*)

User place an order with a coupon code, for example 4.95 EUR off then user is going to Cancel the order. After canceling the order nagetive amout is shown at Admin's Dashboard. This pull request resolve this issue.

Fixed Issues (if relevant)

1. Negative order amount in dashboard latest order when order is cancelled where coupon has been used #18754: Negative order amount in dashboard latest order when order is cancelled where coupon has been used

Manual testing scenarios (*)

1. Place an order with coupon code and without coupon code
2. Cancel the order which is having coupon code
3. Check the Order amount at Admin Dashboard

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[orlangur]

There is another fix for this issue proposed: #18780

@niravkrish what do you think about it?

[niravkrish]

#18780

In that solution he removes discount from the calculation which is already available for calculation in that file.

The issue is only to prevent negative amount displayed on the dashboard.

I am resolving the issue without changing the default functionality.

Like by default total is displayed with discount.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-3560 has been created to process this Pull Request

[magento-engcom-team]

@niravkrish thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[ghost]

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @niravkrish. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.