[Backport] Sample Link Issue in Downloadable product in magento-2.2.6 #19344

[ansari-ziyaurrahman]

Sample Link Issue in Downloadable product. #19344

Description (*)

Fixed issue of Sample Link Issue in Downloadable product.

Fixed Issues (if relevant)

1. Sample Link Issue in Downloadable product. #19344: Sample Link Issue in Downloadable product

Manual testing scenarios (*)

1. Create New product with sample Links.
2. Add and edit links eith multiple products.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Fix for 2.3 440e9eb

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3584 has been created to process this Pull Request

[magento-engcom-team]

@ansari-krish thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[orlangur]

@ansari-krish please cherry-pick 440e9eb properly so that original commit author is preserved.

[magento-engcom-team]

Hi @ansari-krish. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[orlangur]

@sidolov @sivaschenko any idea why this improper PR was merged?

[sivaschenko]

@orlangur why do you consider this PR improper?

[orlangur]

@sivaschenko because it didn't pass code review, here is a request change: #19431 (review)

[sivaschenko]

@orlangur as I can see, the requested commit was added to the pull request after the code review, so the code review was considered outdated.

[orlangur]

@sivaschenko nope, it obviously wasn't: 3b6307b

I'll share a suggestion regarding automated safeguard in Slack.