Skip to content

2.3 #19454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

2.3 #19454

wants to merge 2 commits into from

Conversation

fballiano
Copy link
Contributor

Just a small update for the minimum PHP version and the link to the documentation

Fixes issue #19453

Manual testing scenarios (*)

  1. try to run M2.3 on php5.5
  2. the system tells you you should have php 7.0.something, which is wrong (as from https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html)
  3. with this fix the minimum php version is checked correctly and the error message is also consistent

@magento-engcom-team
Copy link
Contributor

Hi @fballiano
Unfortunately, we only accept Pull Requests to the following branches: 2.2-develop, 2.3-develop.
Please create a new Pull Request and use one of those as a target.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fballiano @magento-engcom-team