Skip to content

min php version fix #19455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2018
Merged

min php version fix #19455

merged 3 commits into from
Dec 5, 2018

Conversation

fballiano
Copy link
Contributor

Just a small update for the minimum PHP version and the link to the documentation

Description (*)

as written here: https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html the min php version is 7.1.3 but the check in this file was wrong (so also the error messages)

Fixed Issues (if relevant)

  1. wrong php version in app/bootstrap.php #19453

Manual testing scenarios (*)

  1. try to run M2.3 on php5.5
  2. the system tells you you should have php 7.0.something, which is wrong (as from https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html)
  3. with this fix the minimum php version is checked correctly and the error message is also consistent

as written here: https://devdocs.magento.com/guides/v2.3/install-gde/system-requirements-tech.html the min php version is 7.1.3 but the check in this file was wrong (so also the error messages)
@magento-engcom-team
Copy link
Contributor

Hi @fballiano. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 29, 2018

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Nov 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3589 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@fballiano thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur
Copy link
Contributor

@magento-engcom-team please include this in 2.3.0 release if possible.

Also, would be nice to add this to some release activity checklist or a "bump minimum required version" doc as in 2.2 bootstrap became out of sync as well: https://github.com/magento/magento2/blob/2.2-develop/composer.json#L11

@orlangur
Copy link
Contributor

Ok, nevermind, 2.3.0 is already released 🤣

@magento-engcom-team magento-engcom-team merged commit ebce9f3 into magento:2.3-develop Dec 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @fballiano. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants