Use semantic theme color variables, including global primary/secondary colors #19467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR updates instances of the predominant blue and orange colors in the Blank and Luma themes to use more semantic variables.
Additionally, it implements global primary and secondary theme colors to make basic global theme changes much easier and more reliable.
There are no visual changes to the default themes on the frontend (except a couple fixes for minor inconsistencies in Luma), and all existing variables (such as button colors) can still be redefined just as before.
However, setting new brand colors in child themes is now much easier and requires fewer code changes.
Fixed Issues
Preconditions
Steps to reproduce
@active__color
Expected result
@color-orange-red1
for their active state should be updated to use the new active color.Actual result
Manual testing scenarios (*)
@theme__color__primary
,@theme__color__primary-alt
, and@theme__color__secondary
.Contribution checklist (*)