Skip to content

Fixed issue with Base Currency for website is CND when PayPal Payflow… #19569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Fixed issue with Base Currency for website is CND when PayPal Payflow… #19569

merged 1 commit into from
Dec 10, 2018

Conversation

jignesh-baldha
Copy link
Member

@jignesh-baldha jignesh-baldha commented Dec 5, 2018

Original Pull Request

#19430

Description (*)

Customers are being billed in USD even though PayPal Payflow Pro is set to use CND. In Magento the order shows CND, but in PayPal the order displays with amounts in USD. The amounts are the same, which means customers are not paying the correct amount.

Manual testing scenarios (*)

  1. Set Base Currency as USD for default config
  2. Creat Canadian website
  3. Set Base Currency and Default Display Currency for Canadian store to Canadian Dollar.
  4. Go to Canadian store on the storefront
  5. Add product to cart
  6. Complete checkout
  7. Invoice the order
  8. Look at different between order details and details shown in PayPal.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Dec 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3619 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants