-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed 19573: Alignment Issue when create a new email template admin #19574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed 19573: Alignment Issue when create a new email template admin #19574
Conversation
Hi @suryakant-krish. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
I have applied a solution for a specific email template section because when I add margin it will affect on other section. Here is my commit id : 72438de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suryakant-krish thanks for the contribution, please see my code review notes.
@@ -147,6 +147,14 @@ | |||
} | |||
} | |||
} | |||
|
|||
&#currently_used_for { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid using id's in css selectors, try to build css selectors based on classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated code using class.
@magento-engcom-team give me test instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you |
Hi @sivaschenko, here is your new Magento instance. |
Hi @sivaschenko, thank you for the review. |
Hi @suryakant-krish. Thank you for your contribution. |
Description (*)
Alignment Issue when create a new email template admin.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)