Skip to content

Fixed 19573: Alignment Issue when create a new email template admin #19574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Alignment Issue when create a new email template admin.

Fixed Issues (if relevant)

  1. Alignment Issue when create a new email template admin. #19573: Alignment Issue when create a new email template admin.

Manual testing scenarios (*)

  1. Login into admin panel > Marketing > Email Templates > Create new Email template Load any default template. Current used For Alignment issue.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@suryakant-krish
Copy link
Contributor Author

I have applied a solution for a specific email template section because when I add margin it will affect on other section.

Here is my commit id : 72438de

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suryakant-krish thanks for the contribution, please see my code review notes.

@@ -147,6 +147,14 @@
}
}
}

&#currently_used_for {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid using id's in css selectors, try to build css selectors based on classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated code using class.

@sivaschenko sivaschenko self-assigned this Dec 5, 2018
@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19574.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Actual result:
image

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3627 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants