Skip to content

Fixed issue 19642- Catalog product action multi select search label icon alignment issue #19643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented Dec 8, 2018

Description (*)

Catalog product action multi select search label icon alignment issue

Fixed Issues (if relevant)

  1. Catalog product action multi select search label icon alignment issue  #19642: Catalog product action multi select search label icon alignment issue

Manual testing scenarios (*)

  1. Admin -> Catalog -> Products -> Open any product -> click onAttribute Set

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3653 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop January 4, 2019 22:42
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop January 4, 2019 22:42
@magento-engcom-team magento-engcom-team merged commit f49c569 into magento:2.3-develop Jan 7, 2019
@ghost
Copy link

ghost commented Jan 7, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants