Skip to content

Configure missing group for core payment methods #19665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2019
Merged

Configure missing group for core payment methods #19665

merged 2 commits into from
Jan 7, 2019

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Dec 8, 2018

Description (*)

It improves UX of default payment methods source model.

Fixed Issues (if relevant)

  1. Payment methods from core source model are not grouped properly #19664

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @wojtekn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Dec 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 8, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3646 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@wojtekn thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@p-bystritsky
Merge remote-tracking branch 'mainline/2.3-develop' into add_missing_…
9566898 
…payment_groups_for_source_model

# Conflicts:
#	app/code/Magento/Authorizenet/etc/config.xml
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 7, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 9566898 into magento:2.3-develop Jan 7, 2019
@ghost
Copy link

ghost commented Jan 7, 2019

Hi @wojtekn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 7, 2019
@sidolov
ENGCOM-3646: Configure missing group for core payment methods #19665
48964bb
@magento-engcom-team
Copy link
Contributor

Hi @wojtekn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Award: bug fix Component: Authorizenet Component: Braintree Component: Paypal Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@wojtekn @magento-cicd2 @magento-engcom-team @orlangur @p-bystritsky