Skip to content

Fixed 19800 Contact us : design improvement #19803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 7, 2019
Merged

Fixed 19800 Contact us : design improvement #19803

merged 7 commits into from
Jan 7, 2019

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Contact us : design improvement #19800: Contact us : design improvement

Manual testing scenarios (*)

  1. Go to frontend > choose to contact us link from footer link.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@suryakant-krish suryakant-krish self-assigned this Dec 15, 2018
@VladimirZaets VladimirZaets self-assigned this Dec 24, 2018
VladimirZaets
VladimirZaets reviewed Dec 24, 2018
View reviewed changes
app/code/Magento/Contact/view/frontend/web/css/source/_module.less Outdated
@@ -0,0 +1,50 @@
// /**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @suryakant-krish, thanks for collaboration. I think // comments tags is redundant

VladimirZaets
VladimirZaets reviewed Dec 24, 2018
View reviewed changes
app/code/Magento/Contact/view/frontend/web/css/source/_module.less Outdated
// * Copyright © Magento, Inc. All rights reserved.
// * See COPYING.txt for license details.
// */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello VladimirZaets,

I have removed // comment tag.

Copy link
Contributor

@DanielRuf DanielRuf Dec 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, please use /** without any extra // at the beginning.

Also please remove the empty lines.

DanielRuf
DanielRuf suggested changes Dec 25, 2018
View reviewed changes
app/code/Magento/Contact/view/frontend/web/css/source/_module.less Outdated
// * Copyright © Magento, Inc. All rights reserved.
// * See COPYING.txt for license details.
// */

Copy link
Contributor

@DanielRuf DanielRuf Dec 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct, please use /** without any extra // at the beginning.

Also please remove the empty lines.

@suryakant-krish
Copy link
Contributor Author

Hello DanielRuf,

I have removed extra space and empty lines.

DanielRuf
DanielRuf suggested changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not correct, please remove the leading // in line 1 and 2 and keep line 3. And there was a line before line 1.

@DanielRuf
Copy link
Contributor

// is for single line comments, /**/ for block comments.

@suryakant-krish
Copy link
Contributor Author

I have updated that.

DanielRuf
DanielRuf suggested changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the closing */ in a new (empty) line.

@suryakant-krish
Copy link
Contributor Author

Added close comment in new empty line.

DanielRuf
DanielRuf suggested changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line is still not correct.
Please see https://github.com/suryakant-krish/magento2/blob/2e08f60e1bd43ccf45a89364e76092cbc6d6da4e/app/code/Magento/Theme/view/frontend/web/css/validate.css

@suryakant-krish
Copy link
Contributor Author

I have updated as well as you have provided link.
https://github.com/suryakant-krish/magento2/blob/2e08f60e1bd43ccf45a89364e76092cbc6d6da4e/app/code/Magento/Theme/view/frontend/web/css/validate.css

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3763 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop January 4, 2019 22:24
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop January 4, 2019 22:24
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 7, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 9bf7ab7 into magento:2.3-develop Jan 7, 2019
@ghost
Copy link

ghost commented Jan 7, 2019

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 7, 2019
@sidolov
ENGCOM-3763: Fixed 19800 Contact us : design improvement #19803
e640a18
@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@suryakant-krish suryakant-krish mentioned this pull request Jan 12, 2019
Merged
4 tasks
@suryakant-krish suryakant-krish mentioned this pull request Jan 22, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

@suryakant-krish suryakant-krish

Labels
Area: Frontend Award: bug fix Component: Contact Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@suryakant-krish @magento-engcom-team @DanielRuf @VladimirZaets @p-bystritsky