#1981 Allow inclusion of a file dev/tools/grunt/themes.local.js

[amenk]

• include local theme configuration, so this can be comited to the local git and shared between developers
• I choose the path grunt instead of grunt/config because it would be bothersome to exclude all standard grunt configs

[amenk]

Unfortunately grunt/local is deleted after composer update

[magento-cicd2]

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments below.

[guz-anton]

Hi Alexander,
Sorry, but I can't accept you changes.
Currently configs/theme.js is just an example of structure. We expect that developer works with own themes. So he should rewrite content of configs/theme.js with own values.

Pros :

• During active development with own theme you don't need waste time for rebuild in-box themes.

Cons :

• This file is under git. Should be not so suitable to rewrite it. But it depend on your workflow.

[amenk]

Yes - the con is the problem. It is deployed via the magento framework composer package, so I can not change it in my git. What about moving the theme.js to app/etc/ and supply a theme.example.js ?

[guz-anton]

moving the theme.js to app/etc/ and supply a theme.example.js

I think its good point.

[amenk]

okay shall I make a PR ?

[guz-anton]

Yes. You are welcome :)

[amenk]

Option 1:
What do you think - should we just delete the dev/tools/grunt/configs/themes.js and replace it with a app/etc/themes.js? That would mean that by default grunt will not work and the dev has to copy the app/etc/themes.template.js to app/etc/themes.js.
Would this break something else?

Options 2:
Just the same way I do it currently, extend the standard themes.js by the local one.

Option 3:
If app/etc/themes.js is present, then ignore the dev/tools/grunt/configs/themes.js

Both options are more complex to implement (okay, 2 more lines). So I would vote for Option 1.

Please comment.

[amenk]

I have implemented the option 1. Actually I force-pushed it to the patch branch, so my old approach was removed from the history. Sorry.

[twiking]

Any update on this one or has it been solved in another way @guz-anton?

[guz-anton]

Hi Tobias,
Still no updates. This issue is team backlog. We don't miss it. But it still needs internal discussion.

I'll notify here in case any changes.

[guz-anton]

Notice about .gitignore - you can exclude helper files locally in any repo. More

$  echo '/app/etc/theme.js' >> .git/info/exclude

[matt-bailey]

Any updates on this? themes.js being overwritten every time we composer install/update is a problem as we need to be able to include our own custom themes in it.

[hostep]

cross-reference with: #4697

Not sure what the best solution between the two options is though.

[guz-anton]

Just a notice: internal ticket MAGETWO-55345 has been created.

[sshrewz]

@amenk, we need you to sign the CLA before we can proceed with further actions on your contribution.

[amenk]

@Snohe I signed that thing a dozen times :-) How to sign it now?

[hostep]

@Snohe: this PR tries to accomplish the same as another accepted PR but in a different way (I think): #4716, so be careful what you do please :)

[guz-anton]

From now you have ability to place local
dev/tools/grunt/configs/themes.loc.js config file.

See implementation for more details.

Thanks for report, ideas and insights.