Skip to content

Issues #6382 - Image Swatch size #19844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

srenon
Copy link
Member

@srenon srenon commented Dec 17, 2018

Description (*)

Not able to change swatch image size in custom theme

Fixed Issues (if relevant)

  1. Image Swatch size change not working #6382: Image Swatch size change not working

Manual testing scenarios (*)

  1. Create a custom theme, then try to change the swatch size. Since it sort alphabetically, theme name much start with a letter before "L" eg "customtheme"

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @srenon. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @srenon , please, sign CLA, otherwise, we can't process your pull request

@pmclain
Copy link
Contributor

pmclain commented Dec 29, 2018

@VladimirZaets This is a backport of #13506 to 2.2-develop.

@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2019

Hi @srenon , signed CLA still missing, I'm closing this PR due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants