Skip to content

Fix spelling in GQL schema comments #19864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix spelling in GQL schema comments #19864

wants to merge 1 commit into from

Conversation

brendanfalkowski
Copy link
Contributor

@brendanfalkowski brendanfalkowski commented Dec 18, 2018

Description (*)

Fix spelling.

Manual testing scenarios (*)

None, affects comments.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 18, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @brendanfalkowski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @brendanfalkowski !

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-3714 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@brendanfalkowski thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur
Copy link
Contributor

@osrecio such contributions should be placed in https://github.com/magento/graphql-ce I believe.

@osrecio
Copy link
Member

osrecio commented Dec 19, 2018

@orlangur My fault, sorry.

@brendanfalkowski We talk internally and I need close this ticket. Can you create it in graphql-ce repo, please.

Thanks and sorry for the inconveniences.

@brendanfalkowski
Copy link
Contributor Author

@orlangur + @osrecio — You're going to have to do more than that to stop me :)

Recreated the PR in the other repo here: magento/graphql-ce#302

@brendanfalkowski brendanfalkowski deleted the feature/gql-fix-spelling branch December 19, 2018 23:40
@brendanfalkowski
Copy link
Contributor Author

Any chance at getting the PR reviewed and approved in the other repo?

@osrecio
Copy link
Member

osrecio commented Jan 8, 2019

Hello @brendanfalkowski Maybe @naydav can help with the PR: magento/graphql-ce#302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants