Skip to content

Fixed Issue #19940 #19947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Dec 23, 2018

Fixed: Exception undefined variable itemsOrderItemId while creating shipment through MSI.

Description (*)

Fixed Undefined variable issue itemsOrderItemId if two products purchased from different source and try to ship each item one by one.

Fixed Issues (if relevant)

  1. magento/magento2: Exception undefined variable itemsOrderItemId while creating shipment through MSI #19940
  2. ...

Manual testing scenarios (*)

  1. Followed all the steps as given in Exception undefined variable itemsOrderItemId while creating shipment through MSI #19940
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3739 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @maheshWebkul721, thanks for collaboration. The PR with the same fix is already created #19941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants