Skip to content

Fixed issue #20113 Widget option labels are misalinged #20114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Fixed issue #20113 Widget option labels are misalinged #20114

merged 2 commits into from
Jan 29, 2019

Conversation

GovindaSharma
Copy link
Contributor

Fixed issue #20113 Widget option labels are misalinged

Description (*)

Fixed issue #20113 Widget option labels are misalinged

Fixed Issues (if relevant)

  1. Widget option labels are misalinged #20113: Widget option labels are misalinged

Manual testing scenarios (*)

  1. In admin content >> Widgets >> Edit widget >> widget options
  2. Add New Widget

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Updated css file
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @GovindaSharma
I hope that soon it is merged.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-3848 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @GovindaSharma , thanks for your contribution. Please see the screenshot:
image
The label is still 1px shifted to the top

@GovindaSharma
Copy link
Contributor Author

@sivaschenko i have fixed the 1px issue.Please check and approve.
Thanks

@osrecio
Copy link
Member

osrecio commented Jan 21, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, here is your new Magento instance.
Admin access: https://pr-20114.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost
Copy link

ghost commented Jan 29, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants