-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix #20229-Fatal error on product-compare page when attributes not configured #20231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #20229-Fatal error on product-compare page when attributes not configured #20231
Conversation
Hi @vivekkumarcedcoss. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
2125e79
to
f18076b
Compare
f18076b
to
db0e8b2
Compare
Hi @aleron75, thank you for the review. |
Hi @vivekkumarcedcoss, thank you for your contribution! |
…ibutes not configured #20231
Hi @vivekkumarcedcoss. Thank you for your contribution. |
Note that this solution changes existing functionality: For non-configured attributes, instead of echoing "No" or "N/A" as it was before, the output will now simply be blank. In order to retain current functionality, instead of checking for |
Description (*)
The
productAttribute
expects second parameter to a string which was failed when$block->getProductAttributeValue($item, $attribute)
returns object due to empty value of attribute.Added a check of
is_string
since it expect second param to astring
.Update list.phtml for issue #20229
Fixed Issues (if relevant)
1.Issue: #20229
2. ...
Manual testing scenarios (*)
Contribution checklist (*)